fix(ClipboardCopy): Adjust aria-labels on buttons#11996
Merged
wise-king-sullyman merged 2 commits intopatternfly:mainfrom Sep 9, 2025
Merged
fix(ClipboardCopy): Adjust aria-labels on buttons#11996wise-king-sullyman merged 2 commits intopatternfly:mainfrom
wise-king-sullyman merged 2 commits intopatternfly:mainfrom
Conversation
Remove aria-labelled by from copy and expand buttons in favor of aria-label. In case of copy button, add new prop for aria-label and pull from hoverTip if not provided. Long term, we will want to further separate these two in a breaking release.
Collaborator
|
Preview: https://pf-react-pr-11996.surge.sh A11y report: https://pf-react-pr-11996-a11y.surge.sh |
rebeccaalpert
requested review from
a team and
wise-king-sullyman
and removed request for
a team
thatblindgeye
requested changes
Sep 9, 2025
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
One file comment below. Can we also add a couple tests for the new prop? One to check that it's getting passed correctly in the ClipboardCopy test file, then one in the ClipboardCopyButton test file itself to check the accessible name.
packages/react-core/src/components/ClipboardCopy/ClipboardCopyButton.tsx
Show resolved
Hide resolved
Member
Author
|
Added prop in and added test in ClipboardCopy. Can't test in ClipboardCopy button since we are already testing the aria-label in there (and that's all that gets passed, not the new prop). |
rebeccaalpert
force-pushed
the
clipboardcopy
branch
from
25ce526 to
75bc492
Compare
rebeccaalpert
force-pushed
the
clipboardcopy
branch
from
75bc492 to
ed33ca8
Compare
thatblindgeye
approved these changes
Sep 9, 2025
wise-king-sullyman
approved these changes
Sep 9, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Remove aria-labelled by from copy and expand buttons in favor of aria-label. In case of copy button, add new prop for aria-label and pull from hoverTip if not provided. Long term, we will want to further separate these two in a breaking release.
Closes #11372