fix(tabs): spread style prop#11981
Conversation
|
Preview: https://pf-react-pr-11981.surge.sh A11y report: https://pf-react-pr-11981-a11y.surge.sh |
| isBox={isBox} | ||
| aria-label="Tabs in the default example" | ||
| role="region" | ||
| style={{ border: '1px solid red' }} |
There was a problem hiding this comment.
I don't think we want to keep this custom style in the example?
There was a problem hiding this comment.
How'd that get in there??? 😅
| style={{ | ||
| [linkAccentLength.name]: currentLinkAccentLength, | ||
| [linkAccentStart.name]: currentLinkAccentStart, | ||
| ...style | ||
| }} |
There was a problem hiding this comment.
Would we want to expose an explicit style prop, or spread props.style here instead? Right now the only place that really has a style prop are Charts components - not a huge deal, but just wondering if we'd want to do that here.
There was a problem hiding this comment.
Ah! I'd take yours/Katie's lead on that, but I think that makes sense and explains why I didn't see any other components doing this.
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Could we add a quick test to check that passing a style prop 1) doesn't override the existing accent styles, and b) adds in the custom styles?
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
5 participants
fixes #11980