fix(Tooltip): added aria attributes for triggerRef#11953
Merged
rebeccaalpert merged 1 commit intopatternfly:mainfrom Aug 12, 2025
Merged
fix(Tooltip): added aria attributes for triggerRef#11953rebeccaalpert merged 1 commit intopatternfly:mainfrom
rebeccaalpert merged 1 commit intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://pf-react-pr-11953.surge.sh A11y report: https://pf-react-pr-11953-a11y.surge.sh |
thatblindgeye
requested review from
a team,
kmcfaul,
nicolethoen and
rebeccaalpert
and removed request for
a team
kmcfaul
approved these changes
Aug 12, 2025
rebeccaalpert
approved these changes
Aug 12, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aided by Cursor
What: Closes #9517
Going this route also resolves an issue seen in our Tooltip ref examples where an aria-describedby/labelledby attribute is always rendered on the trigger, causing axe to flag an error over it. This dynamically renders those attributes when applicable.
The alternative would be just updating MenuItem code so that the Tooltip wraps
<Component>on line 348 to get the tooltip to render properly, but that wouldn't really resolve the underlying problem with how Tooltips can be used - there'd still be open any issues elsewhere either in our own code where a Tooltip is being used with only a triggerRef and no children, or for consumers who are doing that.Additional issues: