fix(table): add pf-m-small to expandable toggle on small tables#11947
Merged
nicolethoen merged 3 commits intopatternfly:mainfrom Jul 30, 2025
Merged
fix(table): add pf-m-small to expandable toggle on small tables#11947nicolethoen merged 3 commits intopatternfly:mainfrom
nicolethoen merged 3 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11947.surge.sh A11y report: https://patternfly-react-pr-11947-a11y.surge.sh |
evwilkin
requested review from
a team,
rebeccaalpert and
wise-king-sullyman
and removed request for
a team
mcoker
reviewed
Jul 29, 2025
| {isOpen !== undefined && ( | ||
| <Button | ||
| className={css(className, isOpen && styles.modifiers.expanded)} | ||
| className={css(className, isOpen && styles.modifiers.expanded, variant === 'compact' && 'pf-m-small')} |
Contributor
There was a problem hiding this comment.
Can you update this to conditionally apply size="sm" instead of adding the class manually?
Member
Author
There was a problem hiding this comment.
@mcoker thanks for that, looks like I'm a little rusty. Updated 👏
wise-king-sullyman
approved these changes
Jul 29, 2025
nicolethoen
approved these changes
Jul 29, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
16 tasks
nicolethoen
pushed a commit
that referenced
this pull request
Aug 4, 2025
* fix(table): add pf-m-small to expandable toggle on small tables * fix(table): add pf-m-small to expandable toggle on Th in compact table * fix(table): add sm button variant in place of hardcode classname
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #11946
This PR adds the
pf-m-smallclass to the expandable row toggle when the table hasvariant="compact", in both the Th and Td components. This corrects the current behavior to match the Core implementation.