fix(Icons): Bring in newer FA icon#11905
Merged
dlabaj merged 1 commit intopatternfly:mainfrom Jul 1, 2025
Merged
Conversation
29d07a6 to
c806734
Compare
Collaborator
|
Preview: https://patternfly-react-pr-11905.surge.sh A11y report: https://patternfly-react-pr-11905-a11y.surge.sh |
We can't bump to latest version of 6 because icons were renamed/dropped. Adding as a custom icon for now.
c806734 to
276019d
Compare
thatblindgeye
approved these changes
Jul 1, 2025
dlabaj
approved these changes
Jul 1, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #11906
Font Awesome dependencies were out of date and Q3 designs will require one of the newer icons, PenToSquare. Updating the package from 5 to 6 seems to get us these, but FA 6 dropped or renamed some icons. Adding as a custom icon for now.
Additional issues: