chore(resize observer): convert to typescript#11901
Merged
nicolethoen merged 1 commit intopatternfly:mainfrom Jul 25, 2025
Merged
chore(resize observer): convert to typescript#11901nicolethoen merged 1 commit intopatternfly:mainfrom
nicolethoen merged 1 commit intopatternfly:mainfrom
Conversation
18 tasks
Collaborator
|
Preview: https://patternfly-react-pr-11901.surge.sh A11y report: https://patternfly-react-pr-11901-a11y.surge.sh |
thatblindgeye
approved these changes
Jul 11, 2025
nicolethoen
requested changes
Jul 25, 2025
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
I don't think the resize observing is happening in these updated examples...
Here is what I'm currently seeing in our published docs
And this is what it looks like on this PR
Contributor
Author
|
For me it is working correctly. Am I missing something? Recording.2025-07-25.194810.mp4 |
Contributor
|
You're right - weird. when i opened it again it appeared to be working... |
nicolethoen
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #11719
The following examples are converted: