chore(chart stack): convert to typescript#11890
Merged
nicolethoen merged 4 commits intopatternfly:mainfrom Jul 25, 2025
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11890.surge.sh A11y report: https://patternfly-react-pr-11890-a11y.surge.sh |
18 tasks
thatblindgeye
requested changes
Jul 11, 2025
| y: number; | ||
| } | ||
|
|
||
| export const ChartStackColorUnordered: React.FunctionComponent = () => { |
Contributor
There was a problem hiding this comment.
Nit: export name should match the file anme
| y: number; | ||
| } | ||
|
|
||
| export const ChartStackHorizontalBottomLegend: React.FunctionComponent = () => { |
Contributor
There was a problem hiding this comment.
For this, let's just update the example, file, and export name to remove "horizontal". Based on other chart examples I imagine this is just meant to show the bottom aligned legend, and it's confusing that this is named "horizontal" when it's not showing the chart with horizontal stacks
thatblindgeye
approved these changes
Jul 14, 2025
nicolethoen
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #11719
The following examples are converted: