feat(Tabs): add the option to disable the Add button#11872
Merged
thatblindgeye merged 2 commits intopatternfly:mainfrom Jun 17, 2025
Merged
feat(Tabs): add the option to disable the Add button#11872thatblindgeye merged 2 commits intopatternfly:mainfrom
thatblindgeye merged 2 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11872.surge.sh A11y report: https://patternfly-react-pr-11872-a11y.surge.sh |
nicolethoen
approved these changes
Jun 17, 2025
thatblindgeye
requested changes
Jun 17, 2025
packages/react-core/src/components/Tabs/__tests__/Tabs.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Tabs/__tests__/Tabs.test.tsx
Outdated
Show resolved
Hide resolved
The button in the Tabs component for adding new tabs can now get disabled if the isAddButtonDisabeled prop is set.
ksiekl
force-pushed
the
isAddButtonDisabled
branch
from
0aa591a to
147d246
Compare
Contributor
Author
|
Thanks @thatblindgeye for the comments! |
thatblindgeye
approved these changes
Jun 17, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11873
This PR adds the option to make the
+button in theTabscomponent disabled, if the isAddButtonDisabled prop is set.Although the change in the code is really small, I'm not fully familiar with the project and couldn't make it run locally to check visually how the component behaves 😢 . Feel free to confirm that it behaves as expected. All tests pass on my end, so it should be good to go.