docs(charts): Move chart theme examples to colors for charts page.#11849
docs(charts): Move chart theme examples to colors for charts page.#11849nicolethoen merged 1 commit intopatternfly:mainfrom
Conversation
|
Preview: https://patternfly-react-pr-11849.surge.sh A11y report: https://patternfly-react-pr-11849-a11y.surge.sh |
|
hi @kmcfaul and/or @thatblindgeye! could you review this change? The goal is for these React examples to appear in a React tab under the "colors-for-charts" page on org, so that the design guidelines will be in their own tab like with other component docs. I think my edits would do that, but not 100% |
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
I assume this will render the page under a "Victory" tab rather than a "React" tab... but I imagine that would be preferred anyway? I'd defer to @kmcfaul but this seems good to me
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
Yeah I believe if the id is the same it will render in a tab based on the repo source. react or victory tab makes sense to me.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
5 participants
Closes #11757