fix: added resultsCountContext prop to pass into the screenReaderText…#11844
Merged
thatblindgeye merged 5 commits intopatternfly:mainfrom May 29, 2025
Merged
fix: added resultsCountContext prop to pass into the screenReaderText…#11844thatblindgeye merged 5 commits intopatternfly:mainfrom
thatblindgeye merged 5 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11844.surge.sh A11y report: https://patternfly-react-pr-11844-a11y.surge.sh |
nicolethoen
reviewed
May 27, 2025
package.json
Outdated
| "packages/react-integration/demo-app-ts" | ||
| ] | ||
| }, | ||
| "dependencies": { |
Contributor
There was a problem hiding this comment.
I'd wager that this shouldn't be a necessary change? What happens if you remove this line and run things locally (yarn install && yarn start)?
nicolethoen
approved these changes
May 28, 2025
thatblindgeye
requested changes
May 29, 2025
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Just a quick change below, otherwise this is looking nice 😎
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
thatblindgeye
approved these changes
May 29, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… prop
What: Closes #11398
Created a new prop that should provide users who are using a screen reader more context regarding the resultsCount badge
Additional issues: