feat(Form): enabled opt-in animations for expandable fieldgroup#11843
feat(Form): enabled opt-in animations for expandable fieldgroup#11843mcoker merged 1 commit intopatternfly:mainfrom
Conversation
|
Preview: https://patternfly-react-pr-11843.surge.sh A11y report: https://patternfly-react-pr-11843-a11y.surge.sh |
thatblindgeye
requested review from
a team,
rebeccaalpert and
wise-king-sullyman
and removed request for
a team
rebeccaalpert
left a comment
rebeccaalpert
left a comment
There was a problem hiding this comment.
Spacing appears slightly off compared with the main site? I'm looking at the spacing above those dividers.
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
Similar to my comment on TreeView - I think there are very valid reasons why a use case might incline a dev to want to dynamically create and render children of field groups. It may that they didn't load all the information from the backend on page load, and for performance reasons will only retrieve values for the collapsed field groups when they are expanded open... Something to keep in mind
@rebeccaalpert looks like the bug is also in Core when I copy+paste the React HTML into a Core example and revert the changes locally (other than bumping the Core versions). @srambach just FYI ^ in Rebecca's screenshot above there's a divider between "Nested field group 2 (non-expandable)" and the text input above it, but there's no spacing between the input and the divider. |
srambach
left a comment
srambach
left a comment
There was a problem hiding this comment.
This looks with with a followup in core to fix the spacing issue.
|
cc @rebeccaalpert patternfly/patternfly#7571 follow up to the issue you mentioned |
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
7 participants
What: Closes #11840
Additional issues: