feat(CC-batch-3): added batch 3#11829
Merged
nicolethoen merged 14 commits intopatternfly:mainfrom Jul 30, 2025
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11829.surge.sh A11y report: https://patternfly-react-pr-11829-a11y.surge.sh Preview: https://pf-react-pr-11829.surge.sh A11y report: https://pf-react-pr-11829-a11y.surge.sh |
Member
|
@mattnolting FYI it looks like the old files within |
Contributor
Author
@evwilkin Great catch, updated |
nicolethoen
requested changes
May 28, 2025
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
All these PRs would be improved I think with a direct link to the PF docs in a comment.
packages/code-connect/components/Breadcrumbs/ExpandableBreadcrumbs.figma.tsx
Outdated
Show resolved
Hide resolved
packages/code-connect/components/CodeEditor/CodeEditor.figma.tsx
Outdated
Show resolved
Hide resolved
kmcfaul
requested changes
May 29, 2025
packages/code-connect/components/Breadcrumbs/BreadcrumbItems.figma.tsx
Outdated
Show resolved
Hide resolved
packages/code-connect/components/Breadcrumbs/ExpandableBreadcrumbs.figma.tsx
Outdated
Show resolved
Hide resolved
| 'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=9802-5857&t=IzSunfrnw18ti37Y-11', | ||
| { | ||
| props: { | ||
| isExpandable: figma.boolean('Expandable'), |
Contributor
There was a problem hiding this comment.
CodeBlock does not have an isExpandable type of prop itself, ExpandableSection is used as a child of CodeBlock for this use case.
packages/code-connect/components/CodeEditor/CodeEditor.figma.tsx
Outdated
Show resolved
Hide resolved
mattnolting
force-pushed
the
feat-CC-batch-3
branch
from
70529b1 to
9f9703c
Compare
nicolethoen
reviewed
Jun 11, 2025
packages/code-connect/components/Breadcrumbs/ExpandableBreadcrumbs.figma.tsx
Outdated
Show resolved
Hide resolved
packages/code-connect/components/CodeEditor/CodeEditor.figma.tsx
Outdated
Show resolved
Hide resolved
mattnolting
force-pushed
the
feat-CC-batch-3
branch
from
de437c8 to
e106426
Compare
mattnolting
commented
Jul 10, 2025
mattnolting
commented
Jul 10, 2025
mattnolting
commented
Jul 10, 2025
kmcfaul
approved these changes
Jul 25, 2025
mattnolting
force-pushed
the
feat-CC-batch-3
branch
from
df33fa3 to
9c1a096
Compare
mattnolting
force-pushed
the
feat-CC-batch-3
branch
from
9c1a096 to
5c8b1c4
Compare
mattnolting
commented
Jul 29, 2025
packages/code-connect/components/Breadcrumbs/ExpandableBreadcrumbs.figma.tsx
Outdated
Show resolved
Hide resolved
kmcfaul
approved these changes
Jul 30, 2025
nicolethoen
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: #11624
Included components:
Component tracker
Figma preview
Resources: