chore(chart legend): convert to typescript#11823
Merged
thatblindgeye merged 5 commits intopatternfly:mainfrom May 19, 2025
Merged
chore(chart legend): convert to typescript#11823thatblindgeye merged 5 commits intopatternfly:mainfrom
thatblindgeye merged 5 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11823.surge.sh A11y report: https://patternfly-react-pr-11823-a11y.surge.sh |
Contributor
Author
|
@thatblindgeye ready for review. |
18 tasks
thatblindgeye
requested changes
May 14, 2025
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Quick comment below. The tooltip example is also not working as expected, only the last legend item triggers a tooltip for me. Havent had a chance to investigate but thinking maybe it's due to the single ref being created
packages/react-charts/src/victory/components/ChartLegend/examples/ChartLegendTooltips.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I'll look into this. |
Contributor
Author
Yup, needed to create ref inside the LegendLabel function. |
kmcfaul
approved these changes
May 19, 2025
thatblindgeye
approved these changes
May 19, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
mattnolting
pushed a commit
to mattnolting/patternfly-react
that referenced
this pull request
Jun 4, 2025
* chore(chart legend): convert to typescript * converted interactive examples * updated chartlegend.md * converted remaining examples * updated usage of hooks and fixed the tooltip example
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #11719
The following examples are converted: