chore(chart donut utilization): convert to typescript part two#11822
Conversation
|
Preview: https://patternfly-react-pr-11822.surge.sh A11y report: https://patternfly-react-pr-11822-a11y.surge.sh |
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Actually, can we update the usage of things like React.useState etc in the examples to import those directly?
So each example file should import whatever hooks and such they're using (typically types like React.FunctionComponent are fine as-is, more things like useState, useEffect, etc and even React.Fragment we want to import) as import {useState...} from 'react', then the markdown file should include a similar import that includes all imports from each of the example files.
The ChartLegend.md file from one of your other PRs shows how that should look.
|
I'll make the changes to this one and other PRs too. |
Mash707
deleted the
chart-donut-utilization-convert-to-typescript-part-two
branch
…rnfly#11822) * chore(chart donut utilization): convert to typescript part two * updated usage of hooks * updated markdown file to include necessary imports
4 participants
Towards #11719
The following examples of Chart Donut will be converted to TypeScript:
This is related to #11819. The remaining 9 examples are converted in this PR to make it easier for reviewing.