chore(chart donut utilization): convert to typescript#11819
Merged
thatblindgeye merged 2 commits intopatternfly:mainfrom May 20, 2025
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11819.surge.sh A11y report: https://patternfly-react-pr-11819-a11y.surge.sh |
Contributor
Author
|
@thatblindgeye ready for review. |
18 tasks
thatblindgeye
approved these changes
May 14, 2025
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Small nit for the file/export names: in case we ever added any other utilization charts for non-donut, we could rename these to ChartDonutUtil.... Not a blocker, though, especially because it could become too verbose for some of these charts.
thatblindgeye
requested changes
May 14, 2025
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Similar comment here as your other utilization PR regarding updating the imports/use of hooks and such.
kmcfaul
approved these changes
May 19, 2025
thatblindgeye
approved these changes
May 19, 2025
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Just needs a rebase to resolve conflicts otherwise lgtm
Mash707
force-pushed
the
chart-donut-utilization-convert-to-typescript
branch
from
f43bbf7 to
d7986fe
Compare
Contributor
Author
|
Rebase done. |
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
mattnolting
pushed a commit
to mattnolting/patternfly-react
that referenced
this pull request
Jun 4, 2025
* chore(chart donut utilization): convert to typescript * updated usage of hooks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #11719
The following examples of Chart Donut will be converted to TypeScript:
Since there are 18 examples, I'll divide this into 2 PRs making it easier for reviewing.
2nd PR - #11822