fix(Table): removed divider for expanded rows#11815
Conversation
| "devDependencies": { | ||
| "@patternfly/patternfly": "6.3.0-prerelease.6", | ||
| "css": "^3.0.0", | ||
| "@adobe/css-tools": "^4.4.2", |
There was a problem hiding this comment.
Context: the original css package was last updated in 2020 and we were getting build errors due to the @starting-style property from Core. This new package is a fork of the original but more up to date.
|
Preview: https://patternfly-react-pr-11815.surge.sh A11y report: https://patternfly-react-pr-11815-a11y.surge.sh |
andrew-ronaldson
left a comment
andrew-ronaldson
left a comment
There was a problem hiding this comment.
Design approved
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Agree with the suggestion for changing the tableExpandableRow logic to keep things from potentially being breaking, but other than that everything looks good.
andrew-ronaldson
left a comment
andrew-ronaldson
left a comment
There was a problem hiding this comment.
design re-approved
| </td> | ||
| </tr> | ||
| <tr | ||
| class="pf-v6-c-table__tr pf-v6-c-table__expandable-row" |
There was a problem hiding this comment.
Deprecated table tests/examples looks like it needs a similar update potentially, but I think that's probably fine in a follow up or until someone opens an issue for deprecated specifically.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
* fix(Table): removed divider for expanded rows * Updated snapshots
6 participants
What: Closes #11812, closes #11807, closes #11808
Table was updated to a more correct logic of applying certain classes from Core as were a few examples updates to show the correct way to set the tables up with those closes.
The animations aspect just needs to have confirmed that accordion, expandable section, and table expansion look good.
Additional issues: