chore(miscellaneous): remove unnecessary eslint disable camelcase comments#11796
Conversation
Mash707
changed the title
|
Preview: https://patternfly-react-pr-11796.surge.sh A11y report: https://patternfly-react-pr-11796-a11y.surge.sh |
|
@thatblindgeye have a look. I ran the |
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
This looks good. Am noticing there's some other files still disabling the camelcase rule that weren't part of the original update for global and chart tokens.
Because of what those ones are being used for (one being an image import, the others being component CSS var tokens), I think it would make sense to follow how MenuContent is importing similar tokens:
Rather than importing something like c_page_section_m_limit_width_MaxWidth, we just import as camelcased in the above file. So something like import pageSectionWidthLimitMaxWidth maybe and so on. There's only 6 of these instances left, would you want to make updates for this @Mash707 ?
|
Sure I'll update them. |
|
Updated the usage as per |
…ments (patternfly#11796) * chore(charts): remove unnecessary eslint disable camelcase comments * remove eslint disable comments * removed extra spaces * update remaining tokens to use camelcase * updated CardDemos.md * updated page.md
4 participants
Closes #11789