feat(MultiTypeaheadSelect): add initialInputValue prop#11791
feat(MultiTypeaheadSelect): add initialInputValue prop#11791thatblindgeye merged 1 commit intopatternfly:mainfrom
Conversation
adamviktora
requested review from
a team,
kmcfaul and
wise-king-sullyman
and removed request for
a team
|
Preview: https://patternfly-react-pr-11791.surge.sh A11y report: https://patternfly-react-pr-11791-a11y.surge.sh |
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Let's add a couple tests with this new prop being introduced, 1 to check that there's no initial input value by default and 1 to check that the prop is setting the input value as expected.
For the removal of that setInputValue('') call, yeah it is odd that the behavior is different from the basic typeahead template, but it is a change. I don't really love the fact that we may have to introduce a new prop just temporarily, but it may be the better route for now to avoid breaking anything for consumers. Similarly if we add a prop for this a couple tests for the behavior would be good if we can.
adamviktora
force-pushed
the
select-multi-typeahead-input-text
branch
from
15cbfae to
866caf4
Compare
|
It is ok for the product team to keep the text removing behavior, so I reverted the |
|
@adamviktora can you resolve the conflicts? |
adamviktora
force-pushed
the
select-multi-typeahead-input-text
branch
from
866caf4 to
88722dd
Compare
|
@thatblindgeye Resolved |
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
4 participants
What: Closes #11790
- also removes thesetInputValue('')line from thecloseMenufunctiononOpenChange- clicking outside of the input or pressing escape) was not consistent with closing the menu by clicking on the toggle and then outside of the input, the example code also doesn't clear the inputclearInputOnMenuClose" (default to true?), which would also clear the input on closing by clicking the toggle (which is not happening now)