chore(chart bullet): convert to typescript part two#11758
Merged
nicolethoen merged 3 commits intopatternfly:mainfrom Apr 21, 2025
Merged
chore(chart bullet): convert to typescript part two#11758nicolethoen merged 3 commits intopatternfly:mainfrom
nicolethoen merged 3 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11758.surge.sh A11y report: https://patternfly-react-pr-11758-a11y.surge.sh |
Contributor
Author
|
@thatblindgeye both the PRs are ready for review. |
18 tasks
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
I think this looks fine, but it would be nice to reduce the repetitive lines of code with some variables (e.g. the primarySegmentedMeasureData prop if it's being repeated with the same values in a single example).
Contributor
Author
|
Nice catch, I didn't check if variables are repeating, will make the necessary changes. |
thatblindgeye
approved these changes
Apr 21, 2025
nicolethoen
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #11719
Related to #11756
Since there are in total 17 examples I have the divided work it into two PRs.
The following examples of ChartArea will be converted to TypeScript: