chore(search input): add a11y labels to examples#11743
Merged
nicolethoen merged 3 commits intopatternfly:mainfrom Apr 21, 2025
Merged
chore(search input): add a11y labels to examples#11743nicolethoen merged 3 commits intopatternfly:mainfrom
nicolethoen merged 3 commits intopatternfly:mainfrom
Conversation
Contributor
Author
|
@thatblindgeye I have not added aria-labels to the deprecated examples, let me know if they need a update too. |
Collaborator
|
Preview: https://patternfly-react-pr-11743.surge.sh A11y report: https://patternfly-react-pr-11743-a11y.surge.sh |
thatblindgeye
requested changes
Apr 10, 2025
packages/react-core/src/components/SearchInput/examples/SearchInputAdvanced.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/SearchInput/examples/SearchInputBasic.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/SearchInput/examples/SearchInputFocusSearch.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/SearchInput/examples/SearchInputWithExpandable.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/SearchInput/examples/SearchInputWithNavigableOptions.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/SearchInput/examples/SearchInputWithSubmitButton.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
thatblindgeye
approved these changes
Apr 14, 2025
nicolethoen
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11400