feat(Truncate): added logic to truncate based on max characters#11742
feat(Truncate): added logic to truncate based on max characters#11742kmcfaul merged 5 commits intopatternfly:mainfrom
Conversation
|
Preview: https://patternfly-react-pr-11742.surge.sh A11y report: https://patternfly-react-pr-11742-a11y.surge.sh |
thatblindgeye
force-pushed
the
iss10892_trueMidTrunc
branch
from
ffe6ebb to
656a30c
Compare
thatblindgeye
requested review from
a team,
mcoker,
rebeccaalpert and
wise-king-sullyman
and removed request for
a team
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
LGTM! Just a comment, but "maxCharsDisplayed" kinda sounds like it might show less characters, but will only show up to whatever the val of maxCharsDisplayed is. As in it would pair with something like minCharsDisplayed. When this prop as it is now is more just charsDisplayed. FWIW, core also has --MinWidth vars used in the truncate component that could be modified by users via a minCharsDisplayed prop.
I see how it also sounds appropriate - it will only show characters up to whatever value is passed.
Not saying anything needs to change, but wanted to share in case anyone else felt similarly.
thatblindgeye
force-pushed
the
iss10892_trueMidTrunc
branch
from
656a30c to
c609395
Compare
rebeccaalpert
left a comment
rebeccaalpert
left a comment
There was a problem hiding this comment.
This looked good to me!
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
This PR is great!
I already approved, but
It's haiku day! Yay!
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
5 participants
What: Closes #10892
Additional issues: