chore(expandable section): improve toggle text to be descriptive#11737
Merged
thatblindgeye merged 4 commits intopatternfly:mainfrom Apr 10, 2025
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11737.surge.sh A11y report: https://patternfly-react-pr-11737-a11y.surge.sh |
Contributor
Author
|
I have not changed the "With custom toggle content" example as it already has a descriptive text, let me if it needs to be changed. |
kmcfaul
approved these changes
Apr 7, 2025
thatblindgeye
requested changes
Apr 9, 2025
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Let's also update the "Show less" toggle text similarly for each example, so "Show less basic example content" and so on
Contributor
Author
|
I did think about this since the example "Indented expandable content" already had a expanded section by default. Forgot to ask ig, anyways will make the changes. |
Mash707
force-pushed
the
improve-toggle-text-to-be-descriptive
branch
from
753dd98 to
908023b
Compare
thatblindgeye
approved these changes
Apr 10, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11394