fix(Nav): added role presentation to NavItemSeparator#11730
Merged
kmcfaul merged 3 commits intopatternfly:mainfrom Apr 17, 2025
Merged
fix(Nav): added role presentation to NavItemSeparator#11730kmcfaul merged 3 commits intopatternfly:mainfrom
kmcfaul merged 3 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11730.surge.sh A11y report: https://patternfly-react-pr-11730-a11y.surge.sh |
dlabaj
approved these changes
Apr 1, 2025
Contributor
dlabaj
left a comment
dlabaj
left a comment
There was a problem hiding this comment.
LGTM just a comment about the TODO.
| ...props | ||
| }: ToolbarItemProps) => { | ||
| if (variant === ToolbarItemVariant.separator) { | ||
| // TODO: consider removing spread props here so we can update Divider role prop to union of |
Contributor
There was a problem hiding this comment.
Do we have an issue for this? Otherwise should we remove this comment?
Contributor
Author
There was a problem hiding this comment.
I updated some logic to have the union type on the new prop so removed this comment
kmcfaul
approved these changes
Apr 7, 2025
Contributor
|
I'd be in favor of moving to Divider long term |
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #11717
Opted to not create an interface to expose for NavItemSeparator, as I'm wondering if we should consider deprecating it and just using the Divider component. Right now NavItemSeparator is just a wordier wrapper for Divider, and we're not doing anything special within it. One purpose of keeping this would be to have documentation explicitly about when to set the props to what (assuming we intend for this component to be used as either a separator between NavItems or just anywhere within a Nav; if the intent is only for between NavItems, then we should consider not allowing role or component to be customized).
Additional issues: