feat(icon-connector): configured icon connector#11693
Closed
mattnolting wants to merge 1 commit intopatternfly:mainfrom
Closed
feat(icon-connector): configured icon connector#11693mattnolting wants to merge 1 commit intopatternfly:mainfrom
mattnolting wants to merge 1 commit intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11693.surge.sh A11y report: https://patternfly-react-pr-11693-a11y.surge.sh |
22aa6c6 to
2b8b0d2
Compare
e5d6d30 to
c8103bc
Compare
c8103bc to
f5f9935
Compare
Contributor
Author
|
closing in favor of #11794 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11620
Update: 4/1/25
There is a file path discrepancy originating for
packages/react-core/codeConnect/data/iconsData.json.node-ids change from branch to branch. Ingesting ajsonfile with absolute paths impedes icons linking to the appropriate Figma component.The actual url and
node-idishttps://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6%3A-Components-Test?node-id=35322-6764&m=devIn the next iteration,
node-ids and base urls should loaded/saved/configured dynamically to avoid this issue.Icon Connection System
Overview
This PR introduces a complete icon generation system for PatternFly React, automating the process of creating and maintaining icon components with seamless Figma connections.
Features
Directory Structure
Technical Details
Usage
Developers can run the following commands: