refactor(CodeEditor): rewrite to become a functional component#11650
Merged
thatblindgeye merged 2 commits intopatternfly:mainfrom Apr 14, 2025
Merged
refactor(CodeEditor): rewrite to become a functional component#11650thatblindgeye merged 2 commits intopatternfly:mainfrom
thatblindgeye merged 2 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11650.surge.sh A11y report: https://patternfly-react-pr-11650-a11y.surge.sh |
logonoff
force-pushed
the
codeeditor4
branch
3 times, most recently
from
e848e80 to
f7dc31b
Compare
thatblindgeye
requested review from
a team,
kmcfaul and
mfrances17
and removed request for
a team
8 tasks
thatblindgeye
requested review from
a team and
rebeccaalpert
and removed request for
a team and
mfrances17
thatblindgeye
requested changes
Apr 10, 2025
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Will also need a rebase
packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx
Outdated
Show resolved
Hide resolved
packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx
Outdated
Show resolved
Hide resolved
packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx
Outdated
Show resolved
Hide resolved
packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx
Outdated
Show resolved
Hide resolved
| filename | ||
| }); | ||
| this.props.onCodeChange(value); | ||
| const handleFileChange = (value: string) => { |
Contributor
There was a problem hiding this comment.
@nicolethoen do you recall the original reason for having a filename state? Didn't seem like it was being used anywhere other than being set.
also make all props optional -- the needed props are already set by `defaultProps`
thatblindgeye
approved these changes
Apr 10, 2025
Firefox workaround appears to be no longer needed as of version 137.0-2.fc41
Member
Author
|
I added an extra prop to |
rebeccaalpert
approved these changes
Apr 10, 2025
dlabaj
approved these changes
Apr 11, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
dlabaj
pushed a commit
that referenced
this pull request
Apr 17, 2025
* refactor(CodeEditor): rewrite to become a functional component also make all props optional -- the needed props are already set by `defaultProps` * feat(CodeEditor): add allow overriding of code download function Firefox workaround appears to be no longer needed as of version 137.0-2.fc41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #11649
Additional issues: split off from #11575 as I realize the changes can be made independently