Chore(DescriptionList): added unique aria-labels#11646
Chore(DescriptionList): added unique aria-labels#11646nicolethoen merged 5 commits intopatternfly:mainfrom
Conversation
|
Need to add |
|
Preview: https://patternfly-react-pr-11646.surge.sh A11y report: https://patternfly-react-pr-11646-a11y.surge.sh |
|
@thatblindgeye have a look once, I have added
|
|
The "in drawer" demo should get published once our next release goes live, but thanks for mentioning that - had to double check it was showing up on our staging site. For the Wizard bug, would you mind opening a bug report for that example? |
Sure , will open a issue. |
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Lot of comments below, just tweaking labels a bit
packages/react-core/src/components/DescriptionList/examples/DescriptionListBasic.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/DescriptionList/examples/DescriptionListColumnFill.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/DescriptionList/examples/DescriptionListCompact.tsx
Outdated
Show resolved
Hide resolved
...ages/react-core/src/components/DescriptionList/examples/DescriptionListCompactHorizontal.tsx
Outdated
Show resolved
Hide resolved
...act-core/src/components/DescriptionList/examples/DescriptionListDefaultResponsiveColumns.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/demos/DescriptionList/examples/DescriptionListInDrawer.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| const tabContent = ( | ||
| <DescriptionList isHorizontal columnModifier={{ lg: '2Col' }}> | ||
| <DescriptionList isHorizontal columnModifier={{ lg: '2Col' }} aria-label="Status list"> |
There was a problem hiding this comment.
Can we make this dynamic based on the activeTabKey state? So the end result is when the Object 1 tab is active, the aria-label is Object 1 status, when Object 2 is active Object 2 status and so on.
There was a problem hiding this comment.
Passing tabIndex as a parameter in tabContent would make this dynamic.
...tion/demo-app-ts/src/components/demos/DescriptionListDemo/DescriptionListBreakpointsDemo.tsx
Outdated
Show resolved
Hide resolved
...act-integration/demo-app-ts/src/components/demos/DescriptionListDemo/DescriptionListDemo.tsx
Outdated
Show resolved
Hide resolved
Mash707
force-pushed
the
add-aria-labels-description-list
branch
from
d60ac8a to
a1e76a6
Compare
|
I have addressed all the suggestions. Let me know if I miss something. |
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Awesome job on this 🎉
4 participants
Closes #11392