Chore(Skeleton): Adding demo to match core#11415
Merged
thatblindgeye merged 3 commits intopatternfly:mainfrom Jan 14, 2025
Merged
Chore(Skeleton): Adding demo to match core#11415thatblindgeye merged 3 commits intopatternfly:mainfrom
thatblindgeye merged 3 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11415.surge.sh A11y report: https://patternfly-react-pr-11415-a11y.surge.sh |
thatblindgeye
requested review from
a team,
bekah-stephens,
lboehling,
mcoker,
nicolethoen and
thatblindgeye
and removed request for
a team
thatblindgeye
requested changes
Jan 14, 2025
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
This looks good! Just one quick change noted below
packages/react-core/src/demos/examples/Skeleton/SkeletonCard.tsx
Outdated
Show resolved
Hide resolved
nicolethoen
approved these changes
Jan 14, 2025
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
after the fix for Eric, this LGTM! 💟
bekah-stephens
approved these changes
Jan 14, 2025
thatblindgeye
approved these changes
Jan 14, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
mattnolting
pushed a commit
to mattnolting/patternfly-react
that referenced
this pull request
Feb 14, 2025
* Chore(Skeleton): Adding demo to match core * Fixes formatting * Adds screenreaderText to Skeleton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #7214