refactor(misc): change imports from '@patternfly/react-core' to direct imports#11376
Merged
thatblindgeye merged 1 commit intopatternfly:mainfrom Jan 14, 2025
Merged
Conversation
…t imports - this change reduces size of CSS that is imported
Collaborator
|
Preview: https://patternfly-react-pr-11376.surge.sh A11y report: https://patternfly-react-pr-11376-a11y.surge.sh |
mfrances17
approved these changes
Jan 10, 2025
Contributor
mfrances17
left a comment
mfrances17
left a comment
There was a problem hiding this comment.
LGTM, consistent with V5 changes... noticed the discrepancies but those were based on differences in the imports. well done. 👍
thatblindgeye
approved these changes
Jan 13, 2025
gitdallas
approved these changes
Jan 13, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
mattnolting
pushed a commit
to mattnolting/patternfly-react
that referenced
this pull request
Feb 14, 2025
…t imports (patternfly#11376) - this change reduces size of CSS that is imported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10618 for v6