fix(DualListSelector): Resolve tsc type issues in PF6#11360
Merged
tlabaj merged 1 commit intopatternfly:mainfrom Dec 19, 2024
Merged
fix(DualListSelector): Resolve tsc type issues in PF6#11360tlabaj merged 1 commit intopatternfly:mainfrom
tlabaj merged 1 commit intopatternfly:mainfrom
Conversation
mfrances17
requested review from
kmcfaul and
wise-king-sullyman
and removed request for
a team
Collaborator
|
Preview: https://patternfly-react-pr-11360.surge.sh A11y report: https://patternfly-react-pr-11360-a11y.surge.sh |
tlabaj
requested review from
thatblindgeye and
tlabaj
and removed request for
thatblindgeye and
tlabaj
tlabaj
approved these changes
Dec 18, 2024
thatblindgeye
approved these changes
Dec 18, 2024
dlabaj
approved these changes
Dec 19, 2024
mattnolting
pushed a commit
to mattnolting/patternfly-react
that referenced
this pull request
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #10695
This is a follow-up to #11346 which was a fix for all found
tsccompile errors in PF5, all of which were occurring inDualListSelector. These errors were also occurring in PF6 so the same changes apply.