fix(FileUpload): Remove empty icon from example#11359
Merged
tlabaj merged 1 commit intopatternfly:mainfrom Jan 6, 2025
Merged
Conversation
mfrances17
requested review from
tlabaj and
wise-king-sullyman
and removed request for
a team
Collaborator
|
Preview: https://patternfly-react-pr-11359.surge.sh A11y report: https://patternfly-react-pr-11359-a11y.surge.sh |
dlabaj
approved these changes
Dec 19, 2024
tlabaj
approved these changes
Jan 6, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
mattnolting
pushed a commit
to mattnolting/patternfly-react
that referenced
this pull request
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #11347
This is a follow-up to #11289 in which the
FileUploadTextWithRestrictionsexample was changed to take advantage ofreact-dropzoneerror codes, and as part of that the double icon issue on error was fixed. But an empty<Icon>remained in the code example, and although it's not visible or breaking anything, it could confuse viewers of the code example. So it's now removed and that part of the example is more simplified.