feat(Table,misc): rewrite column management demo, remove old dnd examples#11295
Merged
wise-king-sullyman merged 4 commits intopatternfly:mainfrom Jan 20, 2025
Merged
feat(Table,misc): rewrite column management demo, remove old dnd examples#11295wise-king-sullyman merged 4 commits intopatternfly:mainfrom
wise-king-sullyman merged 4 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11295.surge.sh A11y report: https://patternfly-react-pr-11295-a11y.surge.sh |
tlabaj
requested review from
a team,
tlabaj and
wise-king-sullyman
and removed request for
a team
Contributor
|
@kmcfaul can you open an issue to track the DragDropSort bug you mention above? |
Contributor
Author
|
Opened #11312 |
kmcfaul
force-pushed
the
dep-dnd-removal
branch
from
2fdd4ed to
547121b
Compare
wise-king-sullyman
requested changes
Dec 20, 2024
Collaborator
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Overall looks great, I did see a bug in the dragable column management demo where the table stops rendering if the drag is done before any columns are toggled on or off that we probably want to fix before merging.
thatblindgeye
approved these changes
Dec 20, 2024
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Other than the above this lgtm
kmcfaul
force-pushed
the
dep-dnd-removal
branch
from
547121b to
e9ec848
Compare
nicolethoen
reviewed
Jan 13, 2025
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
This LGTM!
only, there is a rogue comma between the modal buttons 😆
nicolethoen
approved these changes
Jan 20, 2025
wise-king-sullyman
approved these changes
Jan 20, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
mattnolting
pushed a commit
to mattnolting/patternfly-react
that referenced
this pull request
Feb 14, 2025
…ples (patternfly#11295) * feat(Table,misc): rewrite column management demo, remove old dnd examples * fix basic table column management * fix default filter state * remove rogue comma
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11190.
Also slightly touches up the basic column management demo as the changes to Modal are the same.
There is an issue with
DragDropSortI've noticed but haven't yet debugged, that the DataListItems it creates internally are for some reason duplicating theDataListItemControlcomponent for theDataListCheck, giving it extra padding. I'm not sure why this is happening, as it doesn't occur in theDragDropSortDataList example even with the same content code structure.