feat(FileUpload): expose dropdown error types#11289
Merged
wise-king-sullyman merged 2 commits intopatternfly:mainfrom Dec 2, 2024
Merged
feat(FileUpload): expose dropdown error types#11289wise-king-sullyman merged 2 commits intopatternfly:mainfrom
wise-king-sullyman merged 2 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11289.surge.sh A11y report: https://patternfly-react-pr-11289-a11y.surge.sh |
kmcfaul
approved these changes
Nov 26, 2024
wise-king-sullyman
approved these changes
Dec 2, 2024
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This was referenced Dec 16, 2024
mattnolting
pushed a commit
to mattnolting/patternfly-react
that referenced
this pull request
Feb 14, 2025
* feat(FileUpload): expose dropdown error types * updated due to dropzone changes and fixed legacy bug in example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #10521
This allows devs to capture and act on native react-dropzone error codes. Added an example of doing so to the existing FileUploadWithRestrictions example. Also fixed a legacy bug in that example in which, after dropping an invalid file, the error states were remaining even if subsequently dragging and dropping valid files.