fix(charts): victoryCreateContainer breakage (v5)#10905
Merged
tlabaj merged 2 commits intopatternfly:v5from Sep 11, 2024
Merged
fix(charts): victoryCreateContainer breakage (v5)#10905tlabaj merged 2 commits intopatternfly:v5from
tlabaj merged 2 commits intopatternfly:v5from
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-10905.surge.sh A11y report: https://patternfly-react-pr-10905-a11y.surge.sh |
dlabrecq
force-pushed
the
victory-update
branch
2 times, most recently
from
be74183 to
5c54d41
Compare
dlabrecq
force-pushed
the
victory-update
branch
from
5c54d41 to
e5c12bb
Compare
dlabrecq
changed the title
dlabrecq
changed the title
dlabrecq
force-pushed
the
victory-update
branch
from
e5c12bb to
70fc4fc
Compare
dlabrecq
changed the title
tlabaj
approved these changes
Sep 10, 2024
gitdallas
approved these changes
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems Victory v37.1.0 refactored their
victoryCreateContainerfunction, which breaks anyone using ourcreateContainerfunction from react-charts.Closes #10895