fix(TypeaheadSelect): Correctly show the newly selected item on selection#10792
Merged
tlabaj merged 1 commit intopatternfly:mainfrom Jul 23, 2024
Merged
fix(TypeaheadSelect): Correctly show the newly selected item on selection#10792tlabaj merged 1 commit intopatternfly:mainfrom
tlabaj merged 1 commit intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-10792.surge.sh A11y report: https://patternfly-react-pr-10792-a11y.surge.sh |
kmcfaul
approved these changes
Jul 22, 2024
jenny-s51
approved these changes
Jul 22, 2024
Contributor
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
LGTM, fixes bug with TypeaheadSelect and correctly shows selected item
jeff-phillips-18
force-pushed
the
typeahead-fix
branch
from
c384693 to
06f95b8
Compare
jeff-phillips-18
force-pushed
the
typeahead-fix
branch
from
06f95b8 to
db6e775
Compare
jenny-s51
approved these changes
Jul 23, 2024
Contributor
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
Tested new prop noOptionsAvailableMessage, works as expected in TypeaheadSelect 👍
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
tlabaj
pushed a commit
to tlabaj/patternfly-react
that referenced
this pull request
Jul 31, 2024
kmcfaul
added a commit
that referenced
this pull request
Aug 8, 2024
* fix(TypeaheadSelect): Add callback on clear selection (#10719) * fix(CodeEditor) resizeObserver resize loop (#10644) * fix(CodeEditor) resizeObserver resize loop * yarn * add debounce --------- Co-authored-by: Titani <tlabaj@redhat.com> * cherry pick fix(SimpleSelect,CheckboxSelect): Handle initial selection(s) * (Drag and drop): Updated example for multi list to use flex * docs(Table): add Editable Table example * fix(DragDrop): fix flexgrow type * feat(MultiTypeaheadSelect): Add MultiTypeaheadSelect to react-templates (#10757) * feat(MultiTypeaheadSelect): Add MultiTypeaheadSelect to react-templates * Update packages/react-templates/src/components/Select/MultiTypeaheadSelect.tsx Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com> --------- Co-authored-by: Titani Labaj <39532947+tlabaj@users.noreply.github.com> Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com> * fix(TypeaheadSelect): Correctly show the newly selected item on selection (#10792) * feat(TypeaheadSelect) Add creation options to TypeaheadSelect (#10802) * update MultiTypeaheadSelect to use label instead of chip * chore(deps): upgrade eslint-plugin-react to the latest (#10739) * chore(deps): upgrade `eslint-plugin-markdown` to the latest version (#10738) Signed-off-by: Jon Koops <jonkoops@gmail.com> * resolve merge conflicts * feat(eslint-plugin-patternfly-react): update rules for eslint v9 (#10743) * resolve conflicts for chore(deps): upgrade ESLint to the latest version * fix yarn lint issue * fix yarn lint issue * fix(TypeaheadSelect): Update input value only when appropriate (#10826) * fix lint errors and demo-app --------- Signed-off-by: Jon Koops <jonkoops@gmail.com> Co-authored-by: Jeff Phillips <jephilli@redhat.com> Co-authored-by: Dominik Petřík <77832970+Dominik-Petrik@users.noreply.github.com> Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com> Co-authored-by: Jon Koops <jonkoops@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Closes #10789
Description:
Updates the input text correctly when the selection is updated.
Adds a customizable message to the menu when there are no options available.