fix(ci): prevent V8 crashes during build#10330
Merged
nicolethoen merged 1 commit intopatternfly:mainfrom May 2, 2024
Merged
Conversation
Signed-off-by: Jon Koops <jonkoops@gmail.com>
Collaborator
|
Preview: https://patternfly-react-pr-10330.surge.sh A11y report: https://patternfly-react-pr-10330-a11y.surge.sh |
Contributor
|
Created issue #10331 to reenable caching once the issue has been fixed in a future node update. |
nicolethoen
approved these changes
May 2, 2024
wise-king-sullyman
approved these changes
May 2, 2024
Collaborator
|
Looks like I was a bit late to the party 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the CI will sometimes break due to a Node.js crash that seems related to the way V8 handles the compile cache (nodejs/node#51555). The problem seems to be mitigated by disabling the compile cache for now, and is likely resolved by upgrading to a new LTS version in the future.
This issue seems to only occur on CI, as I was not able to reproduce it locally with the same version of Node.js, and this is likely related to the specific way the GitHub actions runners are set up. So I believe this will not impact local development.