Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-10311.surge.sh A11y report: https://patternfly-react-pr-10311-a11y.surge.sh |
dlabrecq
force-pushed
the
skeletons
branch
5 times, most recently
from
750b5c8 to
7f1165c
Compare
|
This looks great! Thanks so much! |
andrew-ronaldson
approved these changes
May 1, 2024
Collaborator
andrew-ronaldson
left a comment
andrew-ronaldson
left a comment
There was a problem hiding this comment.
Looks good.
We'll need to create a follow up issue for v6 tokens in Design and dev repos.
Thanks for running with this Dan!
tlabaj
reviewed
May 1, 2024
| import chart_bullet_qualitative_range_ColorScale_400 from '@patternfly/react-tokens/dist/esm/chart_bullet_qualitative_range_ColorScale_400'; | ||
| import chart_bullet_qualitative_range_ColorScale_500 from '@patternfly/react-tokens/dist/esm/chart_bullet_qualitative_range_ColorScale_500'; | ||
|
|
||
| // import global_Color_100 from '@patternfly/react-tokens/dist/esm/global_Color_100'; |
Contributor
There was a problem hiding this comment.
Can we remove this commented code?
tlabaj
approved these changes
May 3, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UX design team wants to show chart skeletons in place of a generic empty state.
I created a new theme to fill-in all labels grey, but also removed chart interactions like tooltips, cursors, etc.
Developers can provide their own fake data to represent their graphs or copy the examples provided.
For UX design and mocks, please see #10310
Examples
https://patternfly-react-pr-10311.surge.sh/charts/skeletons