fix(truncate) tooltip shows without truncation#10281
Conversation
|
Preview: https://patternfly-react-pr-10281.surge.sh A11y report: https://patternfly-react-pr-10281-a11y.surge.sh |
dominik-petrik
force-pushed
the
truncate-bug
branch
from
29e4e4d to
46d854e
Compare
| /** Determines whether the tooltip is hidden regardless of visibility **/ | ||
| hidden?: boolean; |
There was a problem hiding this comment.
I'm not sure whether we should introduce this prop, mainly because we already have an "isVisible" prop for manual control of a Tooltip.
Rather than needing to create this prop, we could just conditionally return either the "full" Truncate content (if there is no truncation; basically everything that is currently being passed to Tooltip) or the "full" Truncate content wrapped in the Tooltip (if there is truncation).
We do something similar in ModalBoxTitle.
dominik-petrik
force-pushed
the
truncate-bug
branch
from
46d854e to
08e16f8
Compare
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Very nice 😎 One nit, though, is that rather than using the ResizeObserver constructor, we could try to use our getResizeObserver helper instead. The WizardBody component and the JumpsLinksWithDrawer demo are two examples that are using it in functional components.
dominik-petrik
force-pushed
the
truncate-bug
branch
from
08e16f8 to
44f1c45
Compare
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
4 participants
What: Closes #10053
Additional issues: I have also added
hiddenprop to theTooltipcomponent which is useful both for this issue and in general