Add description list basic demo#10184
Merged
nicolethoen merged 6 commits intopatternfly:mainfrom Jun 6, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-10184.surge.sh A11y report: https://patternfly-react-pr-10184-a11y.surge.sh |
kmcfaul
reviewed
Mar 25, 2024
tlabaj
requested review from
a team,
mattnolting and
mmenestr
and removed request for
a team
Collaborator
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
It looks like the content here is pretty different from the content of the core demo, is that something we're concerned with on these @tlabaj ?
thatblindgeye
requested changes
Apr 23, 2024
packages/react-core/src/demos/DescriptionList/DescriptionList.md
Outdated
Show resolved
Hide resolved
packages/react-core/src/demos/DescriptionList/DescriptionList.md
Outdated
Show resolved
Hide resolved
packages/react-core/src/demos/DescriptionList/examples/DescriptionListBasic.tsx
Show resolved
Hide resolved
packages/react-core/src/demos/DescriptionList/examples/DescriptionListBasic.tsx
Show resolved
Hide resolved
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Couple more nits below but otherwise looking good to me
packages/react-core/src/demos/DescriptionList/examples/DescriptionListBasic.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/demos/DescriptionList/examples/DescriptionListBasic.tsx
Show resolved
Hide resolved
thatblindgeye
approved these changes
Apr 24, 2024
Contributor
I agree with Austin, the content should match core as closely as possible. Could we update the data in the card to more closely align wit core please. |
wise-king-sullyman
requested changes
Apr 30, 2024
Collaborator
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
It looks like there's still some items that aren't lining up with the core demo, for instance the divider not going all the way across the card, the distance between the divider and the heading, the layout and order of the items, and the status being a link:
Contributor
|
Still seeing the divider mismatch on the latest surge. |
Member
Author
@kmcfaul @wise-king-sullyman On local changes look fine but seems changes are not reflecting on surge.
|
wise-king-sullyman
approved these changes
May 10, 2024
Collaborator
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Yep I see that same thing, not sure why
Member
Author
Seems changes are not reflecting on surge. Please check it on local. It seems fine on local. |
mattnolting
reviewed
May 15, 2024
Contributor
mattnolting
left a comment
mattnolting
left a comment
There was a problem hiding this comment.
Code looks great! We need to get the previews working to confirm.
nicolethoen
force-pushed
the
demo-descriptionlist
branch
from
2834643 to
dc49a75
Compare
Contributor
|
@mattnolting I think the preview is fixed if you wouldn't mind a quick CSS review |
mattnolting
approved these changes
May 30, 2024
Contributor
mattnolting
left a comment
mattnolting
left a comment
There was a problem hiding this comment.
Nice, great work! LGTM 🤖
tlabaj
pushed a commit
to tlabaj/patternfly-react
that referenced
this pull request
Jun 17, 2024
* add description list basic demo * fix DashboardWrapper not found issue * implement review comments * add divider and size * update content * fixed layout issues
tlabaj
pushed a commit
to tlabaj/patternfly-react
that referenced
this pull request
Jun 17, 2024
* add description list basic demo * fix DashboardWrapper not found issue * implement review comments * add divider and size * update content * fixed layout issues
tlabaj
pushed a commit
to tlabaj/patternfly-react
that referenced
this pull request
Jun 24, 2024
* add description list basic demo * fix DashboardWrapper not found issue * implement review comments * add divider and size * update content * fixed layout issues
tlabaj
pushed a commit
to tlabaj/patternfly-react
that referenced
this pull request
Jun 25, 2024
* add description list basic demo * fix DashboardWrapper not found issue * implement review comments * add divider and size * update content * fixed layout issues
gitdallas
pushed a commit
that referenced
this pull request
Jun 25, 2024
* docs(Page): add example showing different type prop variants (#10352) * docs(Page): add example showing different type prop variants * docs(Page): make text color white in "subnav" section * docs(Page): rename IDs in example * docs(Table): update column management example to use link button for Cancel action (#10459) * feat(Modal): support ReactNode type for 'title' prop * fix(DatePicker/CalendarMonth): better range styling when some dates are disabled (#10398) * fix(DatePicker/CalendarMonth): range styling when disabled dates * chore(Datepicker): getElementSelectorToFocus function description * feat(MenuToggle): add OUIA support * docs(menu-toggle): Adds docs for split button examples. (#10268) * docs(menu-toggle): Adds docs for split button examples. * Update names of split toggle examples. * Add description list basic demo (#10184) * add description list basic demo * fix DashboardWrapper not found issue * implement review comments * add divider and size * update content * fixed layout issues * Convert demo application to Vite * Upgrade Testing Library dependencies to latest version * upgrade to latest version * upgrade to latest version * upgrade to latest version * chore(deps): replace camel-case with change-case * Masthead: add demo that includes horizontal nav * chore: use protocol for workspace dependencies * chore(deps): upgrade to the latest version * chore(deps): upgrade to the latest version * chore(deps): upgrade to the latest version * chore(deps): remove unused dependency * chore(deps): upgrade to the latest version * chore(deps): ugprade Jest to latest version * chore(deps): upgrade to the latest version * chore(deps): upgrade dependencies to the latest version * chore(deps): upgrade to the latest version * chore(deps): update dependencies * update yarn file * more deps fixes * more deps * fix(build): get our custom TS transformers working again (#10477) * fix(build): get our custom TS transformers working again * chore(deps): Update lock file * Update lock file * chore(deps): Update yarn lock * fix demo app * cherry pick yarn changes * update yarn.lock * updatw snapshots * fix demo app * feat(templates): toggle props & improvements (#10473) * feat(templates): toggle props & improvements * remove toggleContent from typeahead template * update template names * update tests * added SimpleSelect tests * fix yarnlock * fix(CodeEditor) support Mac and PC shortcuts in example (#10472) * updatee lock file --------- Co-authored-by: adamviktora <84135613+adamviktora@users.noreply.github.com> Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> Co-authored-by: Ajay Pratap <ajay.pratap233@gmail.com> Co-authored-by: Austin Sullivan <ausulliv@redhat.com> Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com> Co-authored-by: Dominik Petřík <77832970+Dominik-Petrik@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #7000
Add description list basic demo
Additional issues: