Skip to content

Commit fe176ef

Browse files
committed
feat(CC-batch-4): group review 5 updates
1 parent 582cb3a commit fe176ef

File tree

6 files changed

+10
-23
lines changed

6 files changed

+10
-23
lines changed

packages/code-connect/components/DataList/_1BuildItYourselfBasicRows.figma.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ figma.connect(
99
children: figma.children('*')
1010
},
1111
example: (props) => (
12-
<DataListItem>
12+
<DataListItem aria-labelledby="child-text-id">
1313
<DataListItemRow rowid="<row-id>">{props.children}</DataListItemRow>
1414
</DataListItem>
1515
)

packages/code-connect/components/DataList/_1BuildItYourselfClickableRows.figma.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ figma.connect(
1111
children: figma.children('*')
1212
},
1313
example: (props) => (
14-
<DataListItem>
14+
<DataListItem aria-labelledby="child text id">
1515
<DataListItemRow rowid="<row-id>">{props.children}</DataListItemRow>
1616
</DataListItem>
1717
)

packages/code-connect/components/DataList/_2BaseComponentsControlCell.figma.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@ figma.connect(
3131
{
3232
props: {
3333
isExpandable: figma.boolean('Row expansion', {
34-
true: <DataListToggle onClick={() => {}} isExpanded={false} id="m-ex-toggle1" aria-controls="m-ex-expand1" />,
34+
true: <DataListToggle onClick={() => {}} isExpanded={false} id="toggle1" aria-controls="expand1" />,
3535
false: undefined
3636
}),
3737
isSelectable: figma.boolean('Row select', {
38-
true: <DataListCheck id="ex1-item1" aria-labelledby="ex1-item1" name="ex1-item1" />,
38+
true: <DataListCheck id="check-item1" aria-labelledby="item1" name="item1" />,
3939
false: undefined
4040
})
4141
},

packages/code-connect/components/DualListSelector/DualListHeader.figma.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import figma from '@figma/code-connect';
2-
import { Button, ButtonVariant, DualListSelectorPane } from '@patternfly/react-core';
2+
import { Button, ButtonVariant, DualListSelectorPane, SearchInput } from '@patternfly/react-core';
33
import TimesIcon from '@patternfly/react-icons/dist/esm/icons/times-icon';
44

55
// Documentation for DualListHeader can be found at https://www.patternfly.org/components/dual-list-selector
@@ -21,7 +21,9 @@ figma.connect(
2121
false: undefined
2222
}),
2323
isSearchable: figma.boolean('Has search bar', {
24-
true: `buildSearchInput(true)`,
24+
true: (
25+
<SearchInput value={currentPaneFilters} onChange={() => {}} onClear={() => {}} aria-label={paneSearchLabel} />
26+
),
2527
false: undefined
2628
}),
2729
actions: figma.boolean('Has search bar', {
@@ -50,7 +52,7 @@ figma.connect(
5052
example: (props) => (
5153
// Documentation for DualListHeader can be found at https://www.patternfly.org/components/dual-list-selector
5254
<DualListSelectorPane
53-
// actions={props.actions}
55+
actions={props.actions}
5456
listMinHeight="300px"
5557
onSearch={props.onSearch}
5658
searchInput={props.isSearchable}

packages/code-connect/components/DualListSelector/DualListItemTree.figma.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ figma.connect(
88
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=21279-116342',
99
{
1010
props: {
11-
options: `DualListSelectorTreeItemData[] = buildOptions(isChosen, data, false)`
11+
options: 'see example for tree data'
1212
},
1313
example: (props) => (
1414
<DualListSelectorList>

packages/code-connect/components/DualListSelector/DualListItemTypes.figma.tsx

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)