fix(tools): fix type errors in create-element template - #2873
Merged
Conversation
Commit c9bd577 enabled `isolatedDeclarations`, which introduced these errors in `npm new` generated components: > TS9008: Method must have an explicit return type annotation with --isolatedDeclarations. > render() { > > TS9017: Only const arrays can be inferred with --isolatedDeclarations. > static readonly styles = [styles]; Fixes patternfly#2872
|
Contributor
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "fix(tools): fix type errors in create-element template"
} |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bennypowers
enabled auto-merge (squash)
November 10, 2024 06:37
bennypowers
approved these changes
Nov 10, 2024
bennypowers
left a comment
bennypowers
left a comment
Member
There was a problem hiding this comment.
Just needed a changeset and a fix to package.json
Nice work, and thank you for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit c9bd577 enabled
isolatedDeclarations, which introduced these errors innpm newgenerated components:Fixes #2872
Testing Instructions
See #2872. Tested with