This repository was archived by the owner on Feb 5, 2025. It is now read-only.
fix(pagination): minor css for react-bootstrap pagination dropdown #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priley86
requested review from
andresgalante,
jeff-phillips-18,
jgiardino and
matthewcarleton
priley86
force-pushed
the
dropdown-css
branch
from
0036820 to
3c4f132
Compare
Member
andresgalante
left a comment
andresgalante
left a comment
There was a problem hiding this comment.
Hi @priley86 Although I don't see a technical problem to merge this, it leads me to think how much we should clutter patternfly's core code base for the sake of one JS framework implementation.
If we start treating PF core as a dump site to all possible implementations, then everyone loses. any patternfly user that is not using our React implementation will ship more useless code if we merge this PR.
@jeff-phillips-18 I'll let you decide on this.
Member
|
Hi @andresgalante, @priley86, yeah, it's a balancing act. I think in general we are trying to avoid whenever possible adding less/css to the js framework repos so that patternfly core is the main/single place for Patternlfy less/scss/css. This angular-patternfly issue/epic is an attempt to move less to core where ever possible. |
Member
Author
|
@andresgalante i don't see why pf-core should be scoping css specifically for jquery extensions at this point. Is there anything here that is really pf-react specific though? 🙋♂️ |
Member
|
@andresgalante Is the specificity that is there now required for patternfly? |
Member
|
I see that we do need to provide the original level of specificity in order to override the bootstrap setting. I'm OK with this change since it is really just providing an alternative to using the jquery bootstrap-select. |
jeff-phillips-18
approved these changes
Jan 15, 2018
cdcabrera
approved these changes
Jan 16, 2018
Member
cdcabrera
left a comment
cdcabrera
left a comment
There was a problem hiding this comment.
The selector addition and minor resets look easy enough. Curious how an inherited float was influencing a flex layout... overall lgtm.
This was referenced May 30, 2018
priley86
referenced
this pull request
in ManageIQ/manageiq-v2v
May 31, 2018
The css comes from patternfly/patternfly#910, wrapped in a `.miq-v2v` so that we can be sure this only affects v2v screeens. Unfortunately dialogs get opened directly under body, so any such class needs to live on body. (Fortunately there are no cross-controller ajax transitions in gaprindashvili.)
priley86
referenced
this pull request
in ManageIQ/manageiq-v2v
May 31, 2018
The css comes from patternfly/patternfly#910, wrapped in a `.miq-v2v` so that we can be sure this only affects v2v screeens. Unfortunately dialogs get opened directly under body, so any such class needs to live on body. (Fortunately there are no cross-controller ajax transitions in gaprindashvili.)
AparnaKarve
referenced
this pull request
in ManageIQ/manageiq-v2v
Jun 1, 2018
The css comes from patternfly/patternfly#910, wrapped in a `.miq-v2v` so that we can be sure this only affects v2v screeens. Unfortunately dialogs get opened directly under body, so any such class needs to live on body. (Fortunately there are no cross-controller ajax transitions in gaprindashvili.)
priley86
referenced
this pull request
in ManageIQ/manageiq-v2v
Jun 1, 2018
The css comes from patternfly/patternfly#910, wrapped in a `.miq-v2v` so that we can be sure this only affects v2v screeens. Unfortunately dialogs get opened directly under body, so any such class needs to live on body. (Fortunately there are no cross-controller ajax transitions in gaprindashvili.)
priley86
referenced
this pull request
in ManageIQ/manageiq-v2v
Jun 5, 2018
The css comes from patternfly/patternfly#910, wrapped in a `.miq-v2v` so that we can be sure this only affects v2v screeens. Unfortunately dialogs get opened directly under body, so any such class needs to live on body. (Fortunately there are no cross-controller ajax transitions in gaprindashvili.)
AparnaKarve
referenced
this pull request
in ManageIQ/manageiq-v2v
Jun 6, 2018
The css comes from patternfly/patternfly#910, wrapped in a `.miq-v2v` so that we can be sure this only affects v2v screeens. Unfortunately dialogs get opened directly under body, so any such class needs to live on body. (Fortunately there are no cross-controller ajax transitions in gaprindashvili.)
AparnaKarve
referenced
this pull request
in ManageIQ/manageiq-v2v
Jun 8, 2018
The css comes from patternfly/patternfly#910, wrapped in a `.miq-v2v` so that we can be sure this only affects v2v screeens. Unfortunately dialogs get opened directly under body, so any such class needs to live on body. (Fortunately there are no cross-controller ajax transitions in gaprindashvili.)
priley86
referenced
this pull request
in ManageIQ/manageiq-v2v
Jun 12, 2018
The css comes from patternfly/patternfly#910, wrapped in a `.miq-v2v` so that we can be sure this only affects v2v screeens. Unfortunately dialogs get opened directly under body, so any such class needs to live on body. (Fortunately there are no cross-controller ajax transitions in gaprindashvili.)
AparnaKarve
referenced
this pull request
in ManageIQ/manageiq-v2v
Jun 12, 2018
The css comes from patternfly/patternfly#910, wrapped in a `.miq-v2v` so that we can be sure this only affects v2v screeens. Unfortunately dialogs get opened directly under body, so any such class needs to live on body. (Fortunately there are no cross-controller ajax transitions in gaprindashvili.)
AparnaKarve
referenced
this pull request
in ManageIQ/manageiq-v2v
Jun 14, 2018
The css comes from patternfly/patternfly#910, wrapped in a `.miq-v2v` so that we can be sure this only affects v2v screeens. Unfortunately dialogs get opened directly under body, so any such class needs to live on body. (Fortunately there are no cross-controller ajax transitions in gaprindashvili.)
AllenBW
referenced
this pull request
in ManageIQ/manageiq-v2v
Jun 18, 2018
The css comes from patternfly/patternfly#910, wrapped in a `.miq-v2v` so that we can be sure this only affects v2v screeens. Unfortunately dialogs get opened directly under body, so any such class needs to live on body. (Fortunately there are no cross-controller ajax transitions in gaprindashvili.)
AparnaKarve
referenced
this pull request
in ManageIQ/manageiq-v2v
Jun 19, 2018
The css comes from patternfly/patternfly#910, wrapped in a `.miq-v2v` so that we can be sure this only affects v2v screeens. Unfortunately dialogs get opened directly under body, so any such class needs to live on body. (Fortunately there are no cross-controller ajax transitions in gaprindashvili.)
mzazrivec
referenced
this pull request
in mzazrivec/miq_v2v_ui_plugin
Jul 9, 2018
The css comes from patternfly/patternfly#910, wrapped in a `.miq-v2v` so that we can be sure this only affects v2v screeens. Unfortunately dialogs get opened directly under body, so any such class needs to live on body. (Fortunately there are no cross-controller ajax transitions in gaprindashvili.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to address a minor issue using the React Bootstrap DropdownButton instead of bootstrap-select. The DOM rendered is a tad bit different from bootstrap-select and customizing this via a few minor CSS tweaks seems to be the easier option.
Link to OSUX story:
https://patternfly.atlassian.net/browse/OSUX-339
PF-React PR:
patternfly/patternfly-react#143
Link to React Storybook
Note: I am ignoring the bootstrap-select paddings added to the
dropdown-toggleand would prefer to just leave it atmin-width:autoas to not introduce more CSS.Changes
btn-groupselector as to ensure React Bootstrap button-group is styled closely w/o thebootstrap-selectclassmin-width:autoLink to rawgit and/or image
For example: Here is a link to Alerts on rawgit
This is an image:
PR checklist (if relevant)