Finite wizard #894
Finite wizard #894
Conversation
srambach
requested review from
christiemolloy,
kybaker,
matthewcarleton,
mcarrano,
mceledonia and
mcoker
|
Deploy preview for pf-next ready! Built with commit 8038922 |
mcarrano
left a comment
mcarrano
left a comment
There was a problem hiding this comment.
@srambach This is looking good, but I have a few questions/comments.
- I'm wondering about the spacing between Cancel and other buttons. It feels a bit odd as is since Cancel is implemented as a link button vs, Back and Next that take on Button styling. Would be interested to hear what @kybaker thinks. Also, the way these buttons stack at mobile sizes does not look right.
- I noticed as I preview different screen that the height changes according to the content. I think this will be disorienting as the user clicks through different screens. For a wizard, I expect the dialog to have a fixed height so that it does not change from screen to screen.
Also, the sequence bar has some issues, but I know that is still WIP so I'll reserve comment for now.
|
@mcarrano I agree that the buttons do not wrap well. It is using the toolbar layout. Do you think this is the wrong layout to use, or do you think that toolbar needs to be fixed at very small widths? @kybaker did say to use the link button for Cancel but he can weigh in on whether that is still desired. I can fix the height as I did the width for demonstration purposes, but in reality, this will likely need to be handled by the JS implementation. |
|
closing this for now, will revisit when design is confirmed. |
4 participants
This implements the simple version of a wizard with no sub-steps, called the finite wizard. There is a finite wizard component, and then that component is combined with a modal to make demos showing an example wizard flow.
It is dependent on the sequence, which is still under some discussion, but I would like to start getting this reviewed. Having it out there will help to understand the sequence issues as well.
Please expect that the sequence will be updated when it settles. Comments about the sequence are probably best kept in the sequence PR #849
Fixes #185