Sequence Component (modifications) #849
Conversation
|
Deploy preview for pf-next ready! Built with commit d8fb14f |
src/patternfly/components/Sequence/examples/sequence-overflow-example.hbs
Outdated
Show resolved
Hide resolved
matthewcarleton
left a comment
matthewcarleton
left a comment
There was a problem hiding this comment.
Just two little things :)
…And also the height of the nav to be more responsive also
mcarrano
left a comment
mcarrano
left a comment
There was a problem hiding this comment.
This looks good @christiemolloy . The documentation definitely helps. I still have some questions about use of the status field that hopefully can be resolved when we meet tomorrow.
|
@srambach I included the changes from your PR. Would you mind taking a look at the numbers. On the 7 and 9 there seems to be some cutting off happening because of the switch to em, but I really dont know why. |
|
@srambach never mind, fixed it! |
christiemolloy
changed the title
|
To do: fix coloring, introduce disabled state |
|
@srambach I made all of the updates that this issue/PR was intended to address. I think next step would be to merge this one into yours. And in a separate PR I will take a look at different variations of stepping through the sequence that we can test inside of your wizard. |
|
@srambach @matthewcarleton do you mind taking a final review on this PR so that we can merge it |
|
Are the control arrows being left in now? I thought they were coming out for now? If they are staying and just appearing on hover, then there are some problems as they are causing shifting. |
|
Also, I'm still seeing the sequence flip to light when opened in a new window. Let's talk about how to handle this. |
|
I'm closing this. We can loop back when sequence design is solid. |
5 participants
This closes #848
The issue was created to address small changes that weren't included in the PR that was merged yesterday for the sequence.