fix(DragDrop): Updated to use grab cursor for draggable items by default#7886
Open
tlabaj wants to merge 1 commit intopatternfly:mainfrom
Open
fix(DragDrop): Updated to use grab cursor for draggable items by default#7886tlabaj wants to merge 1 commit intopatternfly:mainfrom
tlabaj wants to merge 1 commit intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://pf-pr-7886.surge.sh A11y report: https://pf-pr-7886-a11y.surge.sh |
srambach
reviewed
Oct 20, 2025
Member
srambach
left a comment
srambach
left a comment
There was a problem hiding this comment.
Our examples are outdated, and I don't think this fix will change anything in React, as the class pf-v6-c-draggable doesn't seem to be used anymore.
It does fix it for the examples as currently implemented in core, but also causes the grab cursor to show up in the examples that are trying to show what happens during dragging, which is confusing.
Created #7901 to update our examples for parity with React. Curious what your thoughts are @mcoker ?
|
This PR has been automatically marked as stale because it has not had activity in the last 60 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to use
grabcursor for draggable items by default. Usegrabbingonly whenpf-m-draggingmodifier is applied.closes: #7882