chore(demo): correct aria attributes on jump links examples#7776
Merged
thatblindgeye merged 7 commits intopatternfly:mainfrom Sep 10, 2025
Merged
Conversation
Collaborator
|
Preview: https://pf-pr-7776.surge.sh A11y report: https://pf-pr-7776-a11y.surge.sh |
thatblindgeye
requested changes
Sep 3, 2025
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
- Let's remove the "navigation" and "list" verbiage from the aria labeling, that'll already get announced by AT
- Can we make updates to the visible text labels for the jump links as patternfly/patternfly-react#11950?
- vertical with inactive subsection will just need an aria-label applied to the nested list - similar to what I mentioned to Rebecca, for now we can just pass an aria-label to that list with something like "Second inactive subsection" or similar unique-but-generic
- Similar to above re: aria-label on nested list for vertical with active subsection
- We just need to remove the aria-label being applied to the expandable toggle buttons as well since there's already the visible text
thatblindgeye
approved these changes
Sep 9, 2025
Contributor
There was a problem hiding this comment.
LGTM!
@mcoker as a followup to this, do we want to update the "Expandable (responsive) with no label" example so that the toggle is just an icon, or remove the example altogether? Currently React allows a toggle withou a visible text label (relying on aria label instead), but we don't explicitly show that in an example. In this Core example, when the toggle appears it has a visible text label.
Collaborator
|
🎉 This PR is included in version 6.3.0-prerelease.66 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7286