fix(card): added missing body color variable#7756
Open
Mash707 wants to merge 2 commits intopatternfly:mainfrom
Open
fix(card): added missing body color variable#7756Mash707 wants to merge 2 commits intopatternfly:mainfrom
Mash707 wants to merge 2 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://pf-pr-7756.surge.sh A11y report: https://pf-pr-7756-a11y.surge.sh |
mcoker
requested changes
Aug 27, 2025
Contributor
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
This looks great, but since this is changing the card body's text color from inherit to our default color, and cards are used quite a bit, would you mind adding inherit as a fallback for the body text color to give users a way to revert this change in case they were relying on inherit?
If you chnage that to color: var(--#{$card}__body--Color, inherit); then someone can revert this change by setting --#{$card}__body--Color: initial;.
|
This PR has been automatically marked as stale because it has not had activity in the last 60 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7386