fix(breadcrumb): add missing font weight css variable#7755
Open
Mash707 wants to merge 2 commits intopatternfly:mainfrom
Open
fix(breadcrumb): add missing font weight css variable#7755Mash707 wants to merge 2 commits intopatternfly:mainfrom
Mash707 wants to merge 2 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://pf-pr-7755.surge.sh A11y report: https://pf-pr-7755-a11y.surge.sh |
mcoker
requested changes
Aug 27, 2025
Contributor
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
Just one comment, otherwise lgtm!
| padding-inline-end: var(--#{$breadcrumb}__link--PaddingInlineEnd); // use a mutable value for alignment control | ||
| font-size: inherit; | ||
| font-weight: var(--#{$breadcrumb}__link--FontWeight); | ||
| font-weight: inherit; |
Contributor
There was a problem hiding this comment.
Technically this would be breaking - if a user had set --#{$breadcrumb}__link--FontWeight previously to add a custom font-weight here, this change will remove their custom weight. You can change it to below, then add --#{$breadcrumb}__link--FontWeight: initial; in the var list at the top of this stylesheet and that will make the font-weight inherit but also allow a user's customization using that variable to continue to work.
Suggested change
| font-weight: inherit; | |
| font-weight: var(--#{$breadcrumb}__link--FontWeight, inherit); |
|
This PR has been automatically marked as stale because it has not had activity in the last 60 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7385