fix(textinputgroup): update placeholder text color for disabled state#7670
Merged
mcoker merged 2 commits intopatternfly:mainfrom Jul 23, 2025
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-7670.surge.sh A11y report: https://patternfly-pr-7670-a11y.surge.sh |
Member
Author
mattnolting
approved these changes
Jul 22, 2025
Collaborator
mattnolting
left a comment
mattnolting
left a comment
There was a problem hiding this comment.
A future consideration, something like this would avoid the issue altogether moving forward, unless the goal is to style disabled placeholder text explicitly. Either way, nice work! Approved
.pf-m-disabled {
&::placeholder {
::placeholder {
color: inherit;
}
}
Collaborator
|
🎉 This PR is included in version 6.3.0-prerelease.42 🎉 The release is available on: Your semantic-release bot 📦🚀 |
rebeccaalpert
pushed a commit
to rebeccaalpert/patternfly
that referenced
this pull request
Jul 24, 2025
mcoker
added a commit
that referenced
this pull request
Jul 29, 2025
* chore(deps): update dependency @patternfly/documentation-framework to v6.15.5 (#7580) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v6.3.0 (#7680) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(backstop): force light mode and fix no motion class (#7653) * chore(all): update visual baseline images (#7610) * chore(inline-edit/popover): remove stray code (#7675) * fix(textinputgroup): update placeholder text color for disabled state (#7670) * chore(deps): update dependency @patternfly/react-core to v6.3.0 (#7681) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-table to v6.3.0 (#7682) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v6.16.0 (#7684) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v6.16.1 (#7689) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update upload-preview.js * Update upload-preview.js * fix: white space change to trigger prerelease * Update README.md * fix(wizard): nav item horizontal alignment fixes (#7693) --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Sarah Rambacher <srambach@redhat.com> Co-authored-by: Evan <8651509+evwilkin@users.noreply.github.com> Co-authored-by: Nicole Thoen <nthoen@redhat.com>
16 tasks
nicolethoen
pushed a commit
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7661
Closes #7671
This PR:
--#{$text-input-group}__text-input--Colorvariable which defaults to the current value ofvar(--pf-t--global--text--color--regular).coloron the text input group text input to the new--#{$text-input-group}__text-input--Colorvariable.Confirmed w/PF design placeholder text should use the on-disabled token, matching pattern used in similar components such as FormControl.
Before:
After: