Skip to content

fix(table): fixed expandable table styles#7654

Merged
dlabaj merged 4 commits intopatternfly:mainfrom
mcoker:table-expandable-fix
Jul 11, 2025
Merged

fix(table): fixed expandable table styles#7654
dlabaj merged 4 commits intopatternfly:mainfrom
mcoker:table-expandable-fix

Conversation

@mcoker
Copy link
Contributor

@mcoker mcoker commented Jul 10, 2025

No description provided.

@patternfly-build
Copy link
Collaborator

patternfly-build commented Jul 10, 2025 •
edited
Loading

Preview: https://patternfly-pr-7654.surge.sh

A11y report: https://patternfly-pr-7654-a11y.surge.sh

@mcoker mcoker requested a review from thatblindgeye July 10, 2025 04:12
@thatblindgeye thatblindgeye mentioned this pull request Jul 10, 2025
Merged
thatblindgeye
thatblindgeye approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Do we need any todo comment/followup to revert any of this in the future, similar to the comment I added in React that Katie suggested?

@mcoker mcoker marked this pull request as ready for review July 10, 2025 20:29
@mcoker
Copy link
Contributor Author

mcoker commented Jul 11, 2025 •
edited
Loading

Backstop report

Changes:

  • 3 new examples missing a reference screenshot (ignore)
  • Compound expandable sections were not full width prior to this PR, this PR makes them full width
  • Star icon rendering (ignore)
  • Spinners in loading states (ignore)

@mcoker
Copy link
Contributor Author

mcoker commented Jul 11, 2025

FWIW here are some backstop reports against the react repo with these changes:

Diff from main to these latest core changes w/ eric's expandable <Tr> logic change - react-main-diff.pdf

Same as ^ except the packages/react-table/src/components/Table/examples dir copied from the 6.2.2 release (so it's using the 6.2.2 example code) - react-main-examples-from-6.2.2.pdf

Diff from the 6.2.2 release to the latest core changes w/ eric's change - react-6.2.2-diff.pdf

@dlabaj dlabaj merged commit d21e7a3 into patternfly:main Jul 11, 2025
4 checks passed
@patternfly-build
Copy link
Collaborator

patternfly-build commented Jul 11, 2025

🎉 This PR is included in version 6.3.0-prerelease.38 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcoker mcoker mentioned this pull request Jul 11, 2025
Closed
@mcoker mcoker linked an issue Jul 11, 2025 that may be closed by this pull request
Bug - Table - table expansion/borders not working #7657
Closed
mcoker added a commit to mcoker/patternfly that referenced this pull request Jul 16, 2025
@mcoker
Revert "fix(table): fixed expandable table styles (patternfly#7654)"
a9ad543 
This reverts commit d21e7a3.
@mcoker mcoker mentioned this pull request Jul 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlabaj dlabaj dlabaj approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug - Table - table expansion/borders not working

4 participants

@mcoker @patternfly-build @dlabaj @thatblindgeye