fix(toolbar-group): let label groups wrap within the toolbar#6987
Merged
mcoker merged 1 commit intopatternfly:v6from Aug 20, 2024
Merged
fix(toolbar-group): let label groups wrap within the toolbar#6987mcoker merged 1 commit intopatternfly:v6from
mcoker merged 1 commit intopatternfly:v6from
Conversation
Collaborator
|
Preview: https://patternfly-pr-6987.surge.sh A11y report: https://patternfly-pr-6987-a11y.surge.sh |
srambach
requested review from
a team,
bekah-stephens,
kaylachumley and
mcoker
and removed request for
a team
mcoker
reviewed
Aug 20, 2024
Contributor
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
LPTM. Here's the visual regression report - toolbar-8.19.24.pdf
The mobile filter groups are unchanged 👍
Member
Author
|
@mcoker are the differences in the search input in the regression tests due to something local to your machine? I don't see a difference between my PR and staging. |
Contributor
andrew-ronaldson
approved these changes
Aug 20, 2024
Collaborator
andrew-ronaldson
left a comment
andrew-ronaldson
left a comment
There was a problem hiding this comment.
Looks good to me!
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.222 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows label groups to wrap within the header rather than flexing them onto one line and having the labels within wrap down excessively.
Here are some examples of the new wrapping with longer label groups
Before:
After:
fixes #6967